Change PENDING_COLOR to (66,114,245) #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the PENDING_COLOR to a shade of blue instead of yellow in order to improve accessibility for colorblind folks. The current shade of yellow is very hard to distinguish from the green SOLVED_COLOR. This change is discussed in Issue icpctools#978. This color choice is Option 2 in that discussion. Screenshots can be found there. If you have further comments on the color choice, please continue the discussion in Issue icpctools#978 rather than on this PR.
niemela
approved these changes
Jun 15, 2024
Collaborator
|
Sorry for the delay @FinnLidbetter - we wanted to get a release out with the current tested code (v2.5) and that is now done. I'm merging this now, and we'll test with the upcoming World Finals as we'll have a good set of screens/LED panels/projectors/big audience for feedback onsite. You're welcome to use the prereleases at any time, and this would be in the next release. |
deboer-tim
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the PENDING_COLOR to a shade of blue instead of yellow in order to improve accessibility for colorblind folks. The current shade of yellow is very hard to distinguish from the green SOLVED_COLOR.
This change is discussed in Issue #978. This color choice is Option 2 in that discussion. Screenshots can be found there. If you have further comments on the color choice, please continue the discussion in Issue #978