Implement new honors awards #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the old honorable mention award template to support both percentiles and 'number of solved problems compared to the lowest medalist'. Add some special cases: * The highest honors should not be displayed as a list or anything * Any list that overlaps or is just below the medalists, should be displayed before resolving medalists
Collaborator
Author
|
@deboer-tim There is at least one bug: if the 13th team is a regional winner, it will show the highest honors before the regional winner, while it should be the other way around. This happens because ResolverLogic has: ListAwardStep step = getListAward(currentRow, false);
if (step != null) {before if (doneWithRow) {
// we've finished resolving a team, check if they have any awardsBut that is probably because of some reason which makes it that we can't just swap that? |
deboer-tim
approved these changes
Sep 4, 2024
Collaborator
Maybe just priority of awards? I'd have to take more time to look at it, but should be an easy enough fix either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the old honorable mention award template to support both percentiles and 'number of solved problems compared to the lowest medalist'.
Fixes #994.
Add some special cases: