Always draw recent background in helper function #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper method paintRecentBackground() was re-checking ContestUtil.isRecent(), but the contest used might be updated concurrently, and in that case a white background was drawn with a null Color, causing white flashing. The helper function is only used to draw recent updates, so this renames the function to paintRecentResultBackground, and removes the extra check.
nickygerritsen
approved these changes
Sep 15, 2024
deboer-tim
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper method
paintRecentBackground()was re-checkingContestUtil.isRecent(), but thecontestused might be updated concurrently, and in that case a white background was drawn with anullColor, causing white flashing. The helper function is only used to draw recent updates, so this renames the function topaintRecentResultBackground, and removes the extra check.white flashing:
