Do not show scoreboard before showing group winners photo screen #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
approved these changes
Sep 16, 2024
4c20175 to
af91c28
Compare
Initially we wanted to not show the scoreboard between two 'list' awards. However, this is not true in general. Imagine we want to show a list with all the silver medalists after resolving fifth place, but also a list of all gold medalists just after that. Then we DO want to show the scoreboard in between, since we want to show the highlighted teams. This made me decide to simplify things a lot: add a parameter to indicate whether we show the scoreboard in between. For now, we know this always comes AFTER another list, so we know we do not have to pause in between. I did add a note so we know what to change if that assumption ever changes.
af91c28 to
4d62e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially we wanted to not show the scoreboard between two 'list' awards. However, this is not true in general. Imagine we want to show a list with all the silver medalists after resolving fifth place, but also a list of all gold medalists just after that. Then we DO want to show the scoreboard in between, since we want to show the highlighted teams. This made me decide to simplify things a lot: add a parameter to indicate whether we show the scoreboard in between. For now, we know this always comes AFTER another list, so we know we do not have to pause in between. I did add a note so we know what to change if that assumption ever changes.