Add back support for team photos to image generator #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CMS started exporting contest archives I had to rewrite the prior logic that pulled from the CMS file attachment format, and the last piece that I hadn't updated was team photos. This removes the old CMS-folder-structure team photo logic and reuses the same contest format function we do for logos and person photos. While I was doing that I fixed a few other things: - Stop warning when team or person photos don't have transparency (code was there for logos). - Fix out of date class header. - Remove the MAX_IMAGE_SIZE image generation. It was there for a couple cases where we've had logos that were >4000px, but it is now already handled by generating a 1080p (desktop) logo.
nickygerritsen
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CMS started exporting contest archives I had to rewrite the prior logic that pulled from the CMS file attachment format, and the last piece that I hadn't updated was team photos. This removes the old CMS-folder-structure team photo logic and reuses the same contest format function we do for logos and person photos.
While I was doing that I fixed a few other things: