Fix svg png same url #1115
Closed
Fix svg png same url #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 20, 2025 03:55
When there are two files with the same name but different extensions, use a different href to refer to them. This can happen when the folder contains logo.png and logo.svg, or any other resource where there are two or more supported file extensions. Fixes icpctools#1111.
For every Trace.ERROR we now optionally also ship to Sentry. There are other calls which are informative from the CDS perspective which are logged to Sentry as they are important in the contest perspective.
This only affects people developing with IntelliJ Idea
When starting P100 we expect the CDS to have a contest and P100 to get that contest in the feed, currently we would get the teamnumber, get the team in the Contest concept for the logo which would fail as the feed is not done reading yet. The proper fix would be to get the "global" property to get if we're done reading the feed and only then starting the presentation (for some of them) but finding that thread was hard.
This reverts commit bf91955. We still didn't get the logo and this got too slow.
Always null out entries in the main array Otherwise, the resolver will only remove the first object when removing multiple objects. Signed-off-by: cubercsl <[email protected]>
Collaborator
|
We merged #1116 in May. Can we close this draft, or do you still want to change something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the the
/organizations/id/logo.{svg,png}issue. Only opening this to make sure no one else works on this in parallel. Did not test with the presentation client yet if it works out of the box.TODOfor now.extcan be added in a better way, this was the result of a long flight of debugging (and not much changes in the end) but a second pass will be needed.