fix: support file references with same name but different extensions #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are two files with the same name but different extensions, use a different href to refer to them. This can happen when the folder contains logo.png and logo.svg, or any other resource where there are two or more supported file extensions. Fixes icpctools#1111.
nickygerritsen
approved these changes
May 22, 2025
| if (ref != null) | ||
| if (ref != null) { | ||
| // update the href if it is already in use (e.g. for logo.svg and logo.png) | ||
| int count = 2; |
Collaborator
There was a problem hiding this comment.
We should increase count, but isn't #1115 better?
Collaborator
Author
There was a problem hiding this comment.
Oh, I missed the change to line 1104 and thought the draft status meant it wasn't quite done. Yeah, that works too, but I think we should pick an option that can't have conflicts and hence doesn't need the warning output, plus remove the TODO.
I had leaned toward not including the file extension in the href originally so was using the counter instead. I think it would probably be ok to just use the real filename too instead of either of these changes, just less pretty hrefs.
Collaborator
|
I want to test with this so will leave mine open and we can discuss there what will be the best option. |
auto-merge was automatically disabled
May 23, 2025 18:21
Pull Request is not mergeable
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are two files with the same name but different extensions, use a different href to refer to them.
This can happen when the folder contains logo.png and logo.svg, or any other resource where there are two or more supported file extensions.
Fixes #1111.