Add Sentry logging for client tools #1112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
May 18, 2025
Collaborator
nickygerritsen
left a comment
There was a problem hiding this comment.
I like sentry so I'm all for it. We should find a way to have the properties file not be hardcoded in git maybe though? I think we could use an env var / system property
Collaborator
Author
My idea was to put it in the .gitignore after this is merged, passing an ENV does also work but makes it harder to set the other properties. So a combination is probably needed. |
Collaborator
Author
|
Linked to: #1076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this often for DOMjudge so it helps to detect some of the raised issues automatically.
I didn't update the eclipse part as I don't know (yet) how to set that one up. I think this can be extended to send the error to Sentry each time that the Trace has a level of
ERRORand merging theTrace&Sentrycalls in a custom wrapper. Before I put in that time I would like to know if this is even something which is wanted.