Add Sentry support for the CDS #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Linked to: #1076 |
nickygerritsen
approved these changes
May 18, 2025
| <httpSession invalidationTimeout="8h" idReuse="true"/> | ||
|
|
||
| <keyStore id="defaultKeyStore" password="{xor}FhwPHAswMDMs" /> | ||
| <!--<ssl id="defaultSSLConfig" keyStoreRef="defaultKeyStore" trustDefaultCerts="true" />--> |
Collaborator
There was a problem hiding this comment.
What does this do and why can't we enable it by default?
Collaborator
Author
There was a problem hiding this comment.
It makes that the JVM/CDS server trusts the certificate of sentry.io. Normally we don't have any certificates in the store so there was an SSL error. If people don't use sentry I didn't see a reason to insert that many certificates at once.
Thinking a bit further about it, I think it's fine to default change this (as the machine already trusts those certs) but wanted to limit the amount of new features as much as possible.
For every Trace.ERROR we now optionally also ship to Sentry. There are other calls which are informative from the CDS perspective which are logged to Sentry as they are important in the contest perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this one should be merged before: #1112 as it already implements some of the improvements for that one.
I choose to also raise errors when another system has issues, mostly because those events are important in a contest but might go unnoticed. If this is accepted I can squash the commits but I didn't want to lose progress if changes are requested.