Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: removeFromHistory #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

fix: removeFromHistory #1128

merged 1 commit into from
May 29, 2025

Conversation

@cubercsl
Copy link
Contributor

@cubercsl cubercsl commented May 28, 2025 •
edited
Loading

Always null out entries in the main array

Otherwise, the resolver will only remove the first object when removing multiple objects.

So there will be almost nothing removed by removeHiddenTeams and removeSubmissionsOutsideOfContestTime.

icpctools/ContestModel/src/org/icpc/tools/contest/model/resolver/ResolverLogic.java

Lines 845 to 850 in 4cff573

public static Contest filter(Contest contest) {
Contest c = removeUnnecessaryTypes(contest);
c.removeHiddenTeams();
c.removeSubmissionsOutsideOfContestTime();
return c;
}

Example event-feed.json

Hidden team makes some submissions. In the resolver logic filter, the team is removed from the history, but some submissions are not.

In the given small event-feed, it will output an error before launch resolver UI, but in a larger event-feed, it will flood the terminal.

Invalid submission: submissions
  id: 10688
  problem_id: genshin-impact-trading
  team_id: domjudge
  language_id: cpp
  files: File Reference List [1]
  contest_time: 3:02:28.223
  time: 2024-11-10T12:02:28.223+08:00

demo

@cubercsl
fix: removeFromHistory
6e321f3 
Always null out entries in the main array

Otherwise, the resolver will only remove the first
object when removing multiple objects.

Signed-off-by: cubercsl <[email protected]>
deboer-tim
deboer-tim approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@deboer-tim deboer-tim merged commit aa899cb into icpctools:main May 29, 2025
4 checks passed
@cubercsl cubercsl deleted the fix-remove-from-history branch May 30, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deboer-tim deboer-tim deboer-tim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cubercsl @deboer-tim