P100 boots presentation too fast #1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
May 25, 2025
This only affects people developing with IntelliJ Idea
When starting P100 we expect the CDS to have a contest and P100 to get that contest in the feed, currently we would get the teamnumber, get the team in the Contest concept for the logo which would fail as the feed is not done reading yet. The proper fix would be to get the "global" property to get if we're done reading the feed and only then starting the presentation (for some of them) but finding that thread was hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When machines are rebooted after contest the tmp gets lost, we tried storing the temp between reboots but this yields other problems. When observing the log we see that the teamid is correctly found but the floor map data is not available yet (which we need) and the
contestfeed donelog entry is only given later. So we think we're too fast starting the presentation while startup is not done yet.The other fix is to restart the presentation with the admin (which was the Luxor solution) but this might be a temporary fix.