Move SVG utility to it's own class #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had 3 places reading/converting SVGs, with multiple copies of the image transcoder and parsing w/h info. This moves it all to a shared SVGUtil class with only 2 public functions: loading SVGs (2 versions) and converting to BufferedImages. Since all the work is now done in the model jar the batik jar and its dependencies no longer need to be exported. Some minor formatting and variable overriding cleanup was automatically applied to the image generator.
nickygerritsen
approved these changes
Jul 2, 2025
vmcj
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 3 places reading/converting SVGs, with multiple copies of the image transcoder and parsing w/h info. This moves it all to a shared SVGUtil class with only 2 public functions: loading SVGs (2 versions) and converting to BufferedImages.
Since all the work is now done in the model jar the batik jar and its dependencies no longer need to be exported.
Some minor formatting and variable overriding cleanup was automatically applied to the image generator.