Fix aspect ratio #1149
Fix aspect ratio #1149
Conversation
|
FWIW I haven't put a huge amount of effort into the CDS scoreboard as we never tell anyone about it so no real 'users'. I'm good with fixes/improvement, but would put more effort into something that would have external users, has a newer technical base, and potentially could be reused by other tools (e.g. maybe scoreboard in the team view I've been slowly building). Re the commits: commit: Move image size to CSS
commit: Keep original aspect ratio
commit: Center the logo over the cell
|
This also moves the layout choices to CSS for consistency.
|
Removed the centering commit, removed the commit of code cleanup. |
It was a simple fix, agree that it isn't the highest prio. |
In case someone provides logo's which are far from squarish the aspect ratio gets lost as the logo is stretched. As I'm not 100% how far we want to go we should just pick the right commits and squash those as the solution.
commit: Move image size to CSS (shows the problem):
commit: Keep original aspect ratio
commit: Center the logo over the cell
For the last one I think it only works when all cells get centered like this. Maybe there should just be a maximum on the lenght of the display name of the team to get a more consistent scoreboard.