Switch from UPC to QR in balloon printout #1140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from custom UPCa drawing code to using a QR code library. QR code scanners aren't significantly more expensive than barcode scanners now, it uses less space (so will conflict with messages less on the printout), has built-in error correction, and we can use 'icpc-balloon-X' instead of just a number.
I've used the qrcodegen library. The 1.8 release is a little stale, but the github repo still has activity and it's not like QR codes have changed a lot lately (and my UPC code was older). I'm putting the library in the model project instead of balloon util so that it can be reused by other tools (like snakeyaml or sentry).