Streaming, and resolved file ref should (only) be file #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this while working on icpctools#1133. When resolving a file reference, the only possible type should be file, not the data (contents) of the file. The original choice of Object was to allow submission reactions to be streamed before the reaction video was done recording, but this path was changed years ago and the current streaming code (sending reactions while they were still being recorded) wasn't even working (and didn't support multiple streams). This fixes the reaction streaming in ContestRESTService (moving it to a common helper on HttpHelper) and then correctly types all resolved file to File to improve typing/readability.
nickygerritsen
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while working on #1133.
When resolving a file reference, the only possible type should be file, not the data (contents) of the file. The original choice of Object was to allow submission reactions to be streamed before the reaction video was done recording, but this path was changed years ago and the current streaming code (sending reactions while they were still being recorded) wasn't even working (and didn't support multiple streams).
This fixes the reaction streaming in ContestRESTService (moving it to a common helper on HttpHelper) and then correctly types all resolved file to File to improve typing/readability.