Support for multiple teams and groups in clarification destinations #1164
Conversation
Adds support for the draft Contest API ability to send clarifications to multiple teams and/or groups. This updates the contest model and all client-side support to support multiple teams and groups. The CDS, presentations, and all other tools will work when pointing to a 2023-06 _or_ draft spec server. By default the CDS will continue to serve the 2023-06 contest API though; if you want the new event feed you need to set the ICPC_CONTEST_API=draft system property as with all other draft spec changes. CDS web pages will need to be updated as well, that will be a separate PR.
vmcj
left a comment
There was a problem hiding this comment.
LGTM but feel free to wait for a review from someone more experienced with the code.
| teamId = clar.getToTeamId(); | ||
|
|
||
| // For now, assume that clarifications to hidden teams are only | ||
| // sent to hidden teams. (i.e. no complex groups or hidden+non-hidden teams) |
There was a problem hiding this comment.
I think this should also become part of the spec, so it's easier for someone to implement the spec and not have this edge case.
There was a problem hiding this comment.
See also my remark above
There was a problem hiding this comment.
Agreed, I've added a topic to the CLICS call.
| team = contest.getTeamById(clar.getToTeamId()); | ||
| if (contest.isTeamHidden(team)) | ||
| return null; | ||
| if (clar.getToTeamIds() != null) { |
There was a problem hiding this comment.
I wonder if it would be better to only hide the clarification if all teams and groups in it are hidden and if not, only hide the team / group IDs of hidden ones? It does complicate stuff though.
There was a problem hiding this comment.
Yeah, I started having questions like 'if a clarification is sent to a (visible) group or teams + a hidden team, should the visible teams see a clarification that doesn't include the hidden team and the hidden team see a different clarification with full data?' Most of these cases are so unlikely in practice we could skip implementing and take the chance nobody cares, or make a minor restriction in the spec to avoid it.
I've added an item to the CLICS agenda. Are you ok merging to get the API change and core support though, and revisiting once the spec closes to figure out which edge cases to support better?
There was a problem hiding this comment.
Yes I'm fine with that
| teamId = clar.getToTeamId(); | ||
|
|
||
| // For now, assume that clarifications to hidden teams are only | ||
| // sent to hidden teams. (i.e. no complex groups or hidden+non-hidden teams) |
There was a problem hiding this comment.
See also my remark above
Adds support for the draft Contest API ability to send clarifications to multiple teams and/or groups.
This updates the contest model and all client-side support to support multiple teams and groups. The CDS, presentations, and all other tools will work when pointing to a 2023-06 or draft spec server.
By default the CDS will continue to serve the 2023-06 contest API though; if you want the new event feed you need to set the ICPC_CONTEST_API=draft system property as with all other draft spec changes.
CDS web pages will need to be updated as well, that will be a separate PR.