Use darkbackground in all ICPC tools #1177
Conversation
During NAC we had to change the banner to make sure it looks nice on Coachview. There was already an issue (icpctools#976) to change the color to Black.
deboer-tim
left a comment
There was a problem hiding this comment.
We've also had banners that only work for light mode, and I'm sure someone is old school and will want that back. (plus of course those who would prefer we pick up the system default...)
IMHO if we're going to do this, at a minimum we should support the same --light option as the presentations (or the reverse). (Or get HLS and the team-view over the line to replace coachview entirely 😄)
My idea was to look at the As you were already working on a replacement for CoachView I didn't want to spend that much time on this. I'll see how much work it is to just implement |
|
I've implemented the |
I don't think you want auto detect anyway, since even light mode windows we often want dark mode presentations |
deboer-tim
left a comment
There was a problem hiding this comment.
I'm not sure we should change the default at this point... but we can swap that part out if anyone complains.
The commented out code should have been removed and may cause warnings in some IDEs, but we can clean that up later.
During NAC we had to change the banner to make sure it looks nice on Coachview. There was already an issue (#976) to change the color to Black.