Specify which registry to trust #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker binary defaults to docker.io as registry. Podman as alternative doesn't and might ship with no default registry so can't build this container. By explicit specifying the registry the risk for inconsistent builds is also decreased in case the GHA ever encounters a similar named container on the GHCR and would not use docker.
deboer-tim
approved these changes
Aug 21, 2025
Collaborator
deboer-tim
left a comment
There was a problem hiding this comment.
This is just locking down what's already there, so approving.
OpenJDK images have been deprecated [1], we should probably switch to Temurin [2] soon.
[1] https://hub.docker.com/_/openjdk
[2] https://hub.docker.com/_/eclipse-temurin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker binary defaults to docker.io as registry. Podman as alternative doesn't and might ship with no default registry so can't build this container.
By explicit specifying the registry the risk for inconsistent builds is also decreased in case the GHA ever encounters a similar named container on the GHCR and would not use docker.