World map logo ratio #1173
World map logo ratio #1173
Conversation
Without it the whole line gets presses to make sure the whole team/university name fits. When this is wider than the box we would press the whole line including the displayed logo. We now cheat and just not draw that logo giving the name a bit more space and prevent the logo from being displayed out of ratio.
The presentation will either display in the old way with everything centered or first display the logo on normal size and shrink the text in the remaining space.
861600f to
20946ca
Compare
|
For the first image, isn't it cutting off the logo to the left and the name on the right? The second doesn't look centred any more, and isn't it also cutting off the long name at the right? The fix I was thinking of was doing a bit more complicated scaling to set just the logo part as 'non-shrinkable' - but that would need to be done carefully as there can be other images (e.g. emojis embedded in the text) that you'd still want to shrink. Not sure it's worth doing that way. |
No my screenshot was just wrong, redoing it was annoying.
It's not the whole screen. I can upload the whole screen if thats better.
So let's leave this open, if we need it at finals we can merge this (or implement it properly) I'll unassign myself from the issue. |
Closes #1171,
I'm not 100% if the logo is now placed in the same location or if the
xshould be calculated differently but on first glance this looks like a fix.I've added 2 commits, for both possible solutions.
I like the 2nd for the consistency
The first has the benefit of giving more space for the name which might be worth it as the logo is already on screen at that moment.