Always prefer SVGs #1187
Merged
Always prefer SVGs #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a very small chance that an SVG just contains a low res image, but in all other cases SVGs are better: the file download time is less, loading is less, and generating an image of any exact size should be comparable to png scaling. This change always picks an SVG as 'best' if one exists in a file reference list, regardless of requested image size.
nickygerritsen
approved these changes
Aug 29, 2025
vmcj
approved these changes
Aug 29, 2025
Collaborator
vmcj
left a comment
There was a problem hiding this comment.
We should make an issue to detect PNGs in SVG for that one edgecase where this is worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a very small chance that an SVG just contains a low res image, but in all other cases SVGs are better: the file download time is less, loading is less, and generating an image of any exact size should be comparable to png scaling. This change always picks an SVG as 'best' if one exists in a file reference list, regardless of requested image size.