Default presentation for presentation client #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to set a default presentation for connected presentation clients. This presentation is set before trying to connect to the CDS. If the CDS doesn't set any presentation then this one is shown; otherwise whatever the CDS says takes over. This avoids the standard ICPC Tools loading page, and allows you to have a default w/o waiting for clients to connect and then setting it in the pres admin. Fixes icpctools#955.
nickygerritsen
approved these changes
Aug 25, 2025
| } | ||
|
|
||
| PresentationInfo pi = StandaloneLauncher.findPresentation(presentations, presStr[0]); | ||
| if (pi == null) |
Collaborator
There was a problem hiding this comment.
Maybe also add an trace here that the presentation doesn't exist?
Collaborator
Author
There was a problem hiding this comment.
findPresentation() already traces and does a system exit if the presentation can't be found or matched so this code is unnecessary and could be removed, only kept it since it matches what the standalone client had.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to set a default presentation for connected presentation clients. This presentation is set before trying to connect to the CDS. If the CDS doesn't set any presentation then this one is shown; otherwise whatever the CDS says takes over.
This avoids the standard ICPC Tools splash page, and allows you to have a default w/o waiting for clients to connect and then setting it in the pres admin.
Fixes #955.