Fix balloon printer and update SWT launcher #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the sentry dependency broke a few of the tool scripts a couple months ago. Instead of the direct fix of adding sentry to all the scripts, I tried to simplify and allow all of them to run against all jars in the lib folder (June 20 / build 1215), but I had forgotten how the SWT launcher works. This may be going further down the rabbit hole, but it simplifies how the SWT launcher works as well, removes unused (and potentially confusing) manifest files, and fixes the scripts to match. # Conflicts: # PresAdmin/scripts/presAdmin.bat # PresAdmin/scripts/presAdmin.sh
vmcj
approved these changes
Aug 31, 2025
Collaborator
vmcj
left a comment
There was a problem hiding this comment.
LGTM but maybe another Java expert should also look at it. I do think this is beter though.
vmcj
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the sentry dependency broke a few of the tool scripts a couple months ago. Instead of the direct fix of adding sentry to all the scripts, I tried to simplify and allow all of them to run against all jars in the lib folder (June 20 / build 1215), but I had forgotten how the SWT launcher works.
This may be going further down the rabbit hole, but it simplifies how the SWT launcher works as well, removes unused (and potentially confusing) manifest files, and fixes the scripts to match.