Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle null values for toTeamIds #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2025
Merged

Handle null values for toTeamIds #1240

merged 1 commit into from
Oct 12, 2025

Conversation

@cubercsl
Copy link
Contributor

@cubercsl cubercsl commented Oct 12, 2025 •
edited
Loading

When sending a broadcast (2023_06 spec), to_team_id is null, and the code creates [null] (an array with a null object) for to_team_ids, causing verification failure with:

Clarification to unknown team null or Clarification between teams

This is introduced from 39ac264

So far, I've only observed that the resolver will be notified of invalid feeds, but this doesn't affect usage. However, there may be other potential impacts since the code uses the array length as some logic

Invalid clarifications (16): Clarification to unknown team null
Invalid clarifications (17): Clarification to unknown team null
Invalid clarifications (17): Clarification between teams
Invalid clarifications (19): Clarification to unknown team null
Invalid clarifications (19): Clarification between teams
Invalid clarifications (21): Clarification to unknown team null
Invalid clarifications (21): Clarification between teams
Invalid clarifications (23): Clarification to unknown team null
Invalid clarifications (23): Clarification between teams
Invalid clarifications (24): Clarification to unknown team null
Invalid clarifications (24): Clarification between teams
Invalid clarifications (26): Clarification to unknown team null
Invalid clarifications (26): Clarification between teams
Invalid clarifications (28): Clarification to unknown team null
Invalid clarifications (28): Clarification between teams
Invalid clarifications (29): Clarification to unknown team null
Invalid clarifications (29): Clarification between teams
Invalid clarifications (31): Clarification to unknown team null
Invalid clarifications (31): Clarification between teams
Invalid clarifications (33): Clarification to unknown team null
Invalid clarifications (33): Clarification between teams
Invalid clarifications (35): Clarification to unknown team null
Invalid clarifications (35): Clarification between teams
Invalid clarifications (37): Clarification to unknown team null
Invalid clarifications (37): Clarification between teams
Invalid clarifications (38): Clarification to unknown team null
Invalid clarifications (38): Clarification between teams
Invalid clarifications (40): Clarification to unknown team null
Invalid clarifications (40): Clarification between teams

@cubercsl
Handle null values for toTeamIds
697e421 
When sending a broadcast (2023_06 spec), `to_team_id` is null,
and the code creates `[null]` for `to_team_ids`,
causing verification failure with:

Clarification to unknown team null
Clarification between teams

This is introduced from 39ac264
@deboer-tim
Copy link
Collaborator

deboer-tim commented Oct 12, 2025

Thanks for the patch 👍🏼

@deboer-tim deboer-tim merged commit 76d8796 into icpctools:main Oct 12, 2025
4 checks passed
@cubercsl cubercsl deleted the patch-1 branch October 12, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deboer-tim deboer-tim deboer-tim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cubercsl @deboer-tim