Add domain validation during ImgixClient initialization#37
Merged
sherwinski merged 3 commits intomasterfrom Mar 7, 2019
Merged
Add domain validation during ImgixClient initialization#37sherwinski merged 3 commits intomasterfrom
sherwinski merged 3 commits intomasterfrom
Conversation
6944323 to
d400994
Compare
jayeb
suggested changes
Mar 7, 2019
Contributor
jayeb
left a comment
There was a problem hiding this comment.
A couple of codestyle nits, but the changes here look good. As a procedural note, we try not to check in dist/* files into branches--those should be built and commited to master during the versioning step of the release process.
d400994 to
cfd65b0
Compare
Contributor
|
🎉 This PR is included in version 0.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a validation that will throw an error if a user attempts to initialize a new
ImgixClientobject with an invalid domain.The validation criteria is based off of the same regex used on dashboard.imgix.com