Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix action box color contrast #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+45 −24
Open

Fix action box color contrast #7125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Accessibility
- Fix the semantics for the empty materials text (:pr:`7096`, thanks :user:`foxbunny`)
- Fix announcements accessibility (:pr:`7098`, thanks :user:`foxbuny`)
- Fix conference description color contrast (:pr:`7118`, thanks :user:`foxbunny`)
- Fix action box color contrast (:pr:`7125`, thanks :user:`foxbunny`)

Internal Changes
^^^^^^^^^^^^^^^^
Expand Down
20 changes: 20 additions & 0 deletions indico/web/client/styles/design_system/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,26 @@ body {
--text-size-abs-xl: 1.5rem;
--text-size-abs-xxl: 2rem;

// Special messages components (action boxes, notices, etc.)
--msg-default-main-color: var(--text-color);
--msg-default-background-color: #f9f9f9;
--msg-default-text-color: var(--text-color);
--msg-highlight-main-color: var(--accent-color);
--msg-highlight-background-color: #edf4fd;
--msg-highlight-text-color: var(--text-color);
--msg-warning-main-color: #aa5302;
--msg-warning-background-color: #feefd5;
--msg-warning-text-color: var(--text-color);
--msg-danger-main-color: #d60000;
--msg-danger-background-color: #ffeded;
--msg-danger-text-color: var(--text-color);
--msg-accept-main-color: #1a8344;
--msg-accept-background-color: #ebfdeb;
--msg-accept-text-color: var(--text-color);
--msg-disabled-main-color: #9f9d9d;
--msg-disabled-background-color: #f9f9f9;
--msg-disabled-text-color: var(--text-secondary-color);

// TODO: Compensates from base font size of 14px coming from SUI.
// This should be set to 1 once SUI is removed.
//
Expand Down
48 changes: 24 additions & 24 deletions indico/web/client/styles/partials/_actionboxes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,54 +115,54 @@
.action-box {
@include action-box();
@include action-box-colors(
$color: $dark-gray,
$emphasis-color: $light-black,
$background-color: $light-gray,
$border-color: $dark-gray
$color: var(--msg-default-text-color),
$emphasis-color: var(--msg-default-main-color),
$background-color: var(--msg-default-background-color),
$border-color: var(--msg-default-main-color)
);

&.highlight {
@include action-box-colors(
$color: $light-black,
$emphasis-color: $blue,
$background-color: $light-blue,
$border-color: $blue
$color: var(--msg-highlight-text-color),
$emphasis-color: var(--msg-highlight-main-color),
$background-color: var(--msg-highlight-background-color),
$border-color: var(--msg-highlight-main-color)
);
}

&.warning {
@include action-box-colors(
$color: $dark-gray,
$emphasis-color: $yellow,
$background-color: $light-yellow,
$border-color: $yellow
$color: var(--msg-warning-text-color),
$emphasis-color: var(--msg-warning-main-color),
$background-color: var(--msg-warning-background-color),
$border-color: var(--msg-warning-main-color)
);
}

&.danger {
@include action-box-colors(
$color: $light-black,
$emphasis-color: $red,
$background-color: $light-red,
$border-color: $red
$color: var(--msg-danger-text-color),
$emphasis-color: var(--msg-danger-main-color),
$background-color: var(--msg-danger-background-color),
$border-color: var(--msg-danger-main-color)
);
}

&.disabled {
@include action-box-colors(
$color: $light-black,
$emphasis-color: $black,
$background-color: $pastel-gray,
$border-color: $black
$color: var(--msg-disabled-text-color),
$emphasis-color: var(--msg-disabled-main-color),
$background-color: var(--msg-disabled-background-color),
$border-color: var(--msg-disabled-main-color)
);
}

&.accept {
@include action-box-colors(
$color: $light-black,
$emphasis-color: $green,
$background-color: $light-green,
$border-color: $green
$color: var(--msg-accept-text-color),
$emphasis-color: var(--msg-accept-main-color),
$background-color: var(--msg-accept-background-color),
$border-color: var(--msg-accept-main-color)
);
}

Expand Down
Loading