Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(inputs.procstat): Use correct values for disk_read_bytes, disk_write_bytes on Linux #17552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

fix(inputs.procstat): Use correct values for disk_read_bytes, disk_write_bytes on Linux #17552

merged 3 commits into from
Sep 22, 2025

Conversation

@apurbagarwal-ag
Copy link
Contributor

@apurbagarwal-ag apurbagarwal-ag commented Sep 1, 2025

Summary

Due to change in gopsutil library, incorrect values of disk_read_bytes and disk_write_bytes were being recorded.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17511

@telegraf-tiger telegraf-tiger bot added area/procstat fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 1, 2025
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 1, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
[[amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip] [arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip] [armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip] [armhf.deb i386.rpm freebsd_armv7.tar.gz ] [i386.deb ppc64le.rpm freebsd_i386.tar.gz ] [mips.deb riscv64.rpm linux_amd64.tar.gz ] [mipsel.deb s390x.rpm linux_arm64.tar.gz ] [ppc64el.deb x86_64.rpm linux_armel.tar.gz ] [riscv64.deb linux_armhf.tar.gz ] [s390x.deb linux_i386.tar.gz ] [ linux_mips.tar.gz ] [ linux_mipsel.tar.gz ] [ linux_ppc64le.tar.gz ] [ linux_riscv64.tar.gz ] [ linux_s390x.tar.gz ]]

@srebhan srebhan changed the title fix(inputs.procstat): use correct values of disk_read_bytes, disk_write_bytes fix(inputs.procstat): Use correct values for disk_read_bytes, disk_write_bytes on Linux Sep 1, 2025
@srebhan
Copy link
Member

srebhan commented Sep 1, 2025

@apurbagarwal-ag are you sure this also works on non-Linux platforms?

@srebhan srebhan self-assigned this Sep 1, 2025
@apurbagarwal-ag
Copy link
Contributor Author

apurbagarwal-ag commented Sep 2, 2025

@apurbagarwal-ag are you sure this also works on non-Linux platforms?

@srebhan this would not work in non-Linux platforms. gopsutil says // DiskReadBytes is a number of disk I/O write in bytes. Currently only Linux has this value. Will fix this.

@srebhan srebhan added the waiting for response waiting for response from contributor label Sep 5, 2025
@kuwtnazar-byte
Copy link

kuwtnazar-byte commented Sep 18, 2025

https://github.com/ossf/osv-schema/tree/f1e868d0beb6a440c3ad038d564bb9e06536ec40/tools

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 18, 2025
@srebhan
Copy link
Member

srebhan commented Sep 18, 2025

@kuwtnazar-byte what exactly has that link to do with this PR?

@srebhan srebhan added the waiting for response waiting for response from contributor label Sep 18, 2025
@apurbagarwal-ag
Copy link
Contributor Author

apurbagarwal-ag commented Sep 18, 2025

@srebhan I have kept the behavior unchanged for non-linux platforms. ptal.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 18, 2025
srebhan
srebhan approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apurbagarwal-ag!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 19, 2025
@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan Sep 19, 2025
skartikey
skartikey approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apurbagarwal-ag Thanks for the contribution!

@skartikey skartikey merged commit 0bf7138 into influxdata:master Sep 22, 2025
22 of 24 checks passed
@github-actions github-actions bot added this to the v1.36.2 milestone Sep 22, 2025
srebhan pushed a commit that referenced this pull request Sep 29, 2025
@apurbagarwal-ag @srebhan
fix(inputs.procstat): Use correct values for disk_read_bytes, disk_wr…
c2fdf18 
…ite_bytes on Linux (#17552)

(cherry picked from commit 0bf7138)
skartikey pushed a commit to skartikey/telegraf that referenced this pull request Sep 30, 2025
@apurbagarwal-ag @skartikey
fix(inputs.procstat): Use correct values for disk_read_bytes, disk_wr…
b1846a9 
…ite_bytes on Linux (influxdata#17552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skartikey skartikey skartikey approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@skartikey skartikey

Labels

area/procstat fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.36.2

Development

Successfully merging this pull request may close these issues.

Incorrect values of disk_read_bytes and disk_write_bytes recorded in Linux

5 participants

@apurbagarwal-ag @srebhan @kuwtnazar-byte @skartikey @mstrandboge