Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix type errors #128

@not-my-profile

Description

@not-my-profile

I'm currently working on making the codebase type check with pyright.

From the 180 type errors in src on main I'm already down to 43. The following questions remain:

  • DatReader is calling a needle_out method on the out: EmbPattern which doesn't exist, apparently this bug has existed since the code was introduced in 6187bd3
  • Should the stitch coordinates be int or float? Most readers seem to read integers, however some are currently reading floats (e.g. MitReader due to the MIT_SIZE_CONVERSION_RATIO and CsvReader explicitly converts the coordinates to float).

/cc @kaalleen

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions