Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Shastick
Copy link
Contributor

@Shastick Shastick commented Jul 14, 2025

OIR and CR synchronization scenarios check that entities are properly synchronized via direct access as well as via search (which additionally allows to check if the area of an entity is synchronized).

These checks happen in distinct steps which currently still reference the same documentation fragment, which leads to the situation we'd like to avoid that is described in #975.

This PR splits the sync.md fragment into fragments that respectively handle the direct query and the search, so no "documented but not tested" check is present in the reports for the relevant checks.

Progress on #975

@Shastick Shastick force-pushed the cr-sync-doc-reorg branch 3 times, most recently from dd7cb87 to 74285ff Compare July 14, 2025 15:41
@Shastick Shastick changed the title [uss_qualifier] constraint reference synchronization: documented checks cleanup [uss_qualifier] constraint reference synchronization: cleanup search/get-specific checks Jul 15, 2025
@Shastick Shastick changed the title [uss_qualifier] constraint reference synchronization: cleanup search/get-specific checks [uss_qualifier] CR/OIR sync: cleanup search/get-specific checks Jul 15, 2025
@Shastick Shastick marked this pull request as ready for review July 15, 2025 10:01
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment.

@@ -0,0 +1,58 @@
# Synchronize operational intent reference fields test step fragment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now duplicated as monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/oir/sync.md still exists. I assume it was meant to rename sync.md to sync_fields.md just like for the constraint references?

Copy link
Contributor Author

@Shastick Shastick Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this needs fixing, sync.md should be removed

@Shastick Shastick force-pushed the cr-sync-doc-reorg branch from 74285ff to e37385e Compare July 16, 2025 12:38
@Shastick Shastick force-pushed the cr-sync-doc-reorg branch from e37385e to c283402 Compare July 16, 2025 12:41
@mickmis mickmis merged commit bbe26da into interuss:main Jul 17, 2025
21 checks passed
@mickmis mickmis deleted the cr-sync-doc-reorg branch July 17, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants