feat(http): Apply overrideUserAgent to requests #7906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markemer
approved these changes
Mar 7, 2025
markemer
approved these changes
Mar 18, 2025
Member
markemer
left a comment
There was a problem hiding this comment.
Re-upping my approval here. That's a heck of an android bug, but looks like it works.
jcesarmobile
requested changes
Mar 25, 2025
Member
jcesarmobile
left a comment
There was a problem hiding this comment.
Added some minor comments
android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
android/capacitor/src/main/java/com/getcapacitor/WebViewLocalServer.java
Outdated
Show resolved
Hide resolved
android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
jcesarmobile
requested changes
Mar 26, 2025
android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
| // https://issues.chromium.org/issues/40450316 | ||
| // x-cap-user-agent contains the user agent set in JavaScript | ||
| String userAgentValue = headers.getString("x-cap-user-agent"); | ||
| if (userAgentValue != null && !userAgentValue.isEmpty()) { |
Member
There was a problem hiding this comment.
Suggested change
| if (userAgentValue != null && !userAgentValue.isEmpty()) { | |
| if (userAgentValue != null) { |
I noticed iOS allows empty strings, so we should also allow them for Android
android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java
Outdated
Show resolved
Hide resolved
jcesarmobile
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the Cap Config values of
overrideUserAgent(orios.overrideUserAgent|android.overrideUserAgent) and apply them to CapacitorHttp requests. Also handles User-Agent headers set from JavaScript on Android.closes #7063