Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@panteleymonchuk
Copy link
Collaborator

Description of change

fixes #1049

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Change route

  1. open visualizer
  2. navigate to another route
  3. navigate to visualizer again
    Result before changes: visualizer doesn't show new blocks
    Expected result: visualizer should show new blocks from scratch

Change network

  1. open visualizer
  2. navigate to another network (if you can't because devtool overlapping, you can turn off it in VisualizerInstance.tsx, features.statsEnabled
  3. navigate to visualizer again
    Result before changes: visualizer show same stream
    Expected result: visualizer change network, resubscribe and stream properly network

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • [] My code follows the contribution guidelines for this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk changed the base branch from main to dev February 6, 2024 10:33
# Conflicts:
#	client/src/features/visualizer-threejs/VisualizerInstance.tsx
@panteleymonchuk panteleymonchuk marked this pull request as ready for review February 6, 2024 11:00
…h-route-2

# Conflicts:
#	client/src/features/visualizer-threejs/VisualizerInstance.tsx
@msarcev msarcev merged commit 947bc42 into dev Feb 6, 2024
@msarcev msarcev deleted the feat/issues-1049-switch-route-2 branch February 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Fix blocks not streams when navigating to another tab or switch network

3 participants