Use table alias in WHERE clause when JOINing #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table alias is used for the main table, it's not valid according to the SQL standard to refer to it by it's "real name" (see http://www.postgresql.org/docs/8.2/static/queries-table-expressions.html #QUERIES-TABLE-ALIASES). This causes problems when doing JOIN with a table alias for the "main table", since previous code always used table name. Now, we check for a table alias.
|
Thank you for the pull request, code and test. This looks good to merge! |
|
Merged in commit d477a0c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table alias is used for the main table, it's not valid according to the SQL standard to refer to it by its "real name" anymore (see http://www.postgresql.org/docs/8.2/static/queries-table-expressions.html#QUERIES-TABLE-ALIASES).
This causes problems when doing JOIN with a table alias for the "main table", since previous code always used the table name. Now, the conditon code checks for presence of a table alias and uses that if available.