Testing fix #173
Closed
Testing fix #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing: Checks the parameter array to ensure the correct number of values inside the parameter with sequential integer indexes. Production: Strips out any non-integer indexes from the parameter array inside the _log_query function.
Fixed regex issue that caused almost all tests to fail.
Updated regex to disregard placeholders within quotes.
Fixed the regex not having backslashes escaped.
Added debug code to see why it's failing.
Added some more debug code.
Changed some debugging code.
Updated preg_match_all parameters.
Remove some empty results from the array before checking.
|
Is this really an issue. I am not sure in what instance this would be useful. Please could you give some examples. |
|
This is mainly for testing that the concatenated keys PR gets properly
|
|
Merged into develop with thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should validate that all the arrays are integer indexes only which is the only type of indexes PDO accepts when using question mark placeholders in queries, it generates errors otherwise.