Improve shell detection #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32b1be0 to
1717bc9
Compare
SHELL in environment is not necessarily the current shell; POSIX specifies it as the user's preferred one. Use parent process name primarily instead, if available. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
|
Just wondering if there's anything I could do to nudge this forward ;) |
mjgiarlo
reviewed
Mar 8, 2022
Comment on lines
+85
to
+93
| var shellExe string | ||
| proc, err := process.NewProcess(int32(os.Getppid())) | ||
| if err == nil { | ||
| shellExe, _ = proc.Exe() | ||
| } | ||
| if shellExe == "" { | ||
| shellExe = os.Getenv("SHELL") | ||
| } | ||
| cfg.Shell = detectShell(shellExe) |
There was a problem hiding this comment.
Looks like these changes broke some of the BSD builds. Not sure how big of a deal that is, though.
There was a problem hiding this comment.
Looks like a gopsutil bug, #345 should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHELL in environment is not necessarily the current shell; POSIX
specifies it as the user's preferred one.
Use parent process name primarily instead, if available.
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
Case in point, in my Ubuntu 20.04: