Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… #391

wants to merge 1 commit into from

Conversation

@philion
Copy link

@philion philion commented Dec 13, 2023 •
edited
Loading

…' field doens't erase a valid venv.

Specific issues:

  1. No check for VIRTUAL_ENV_PROMPT.
  2. Logic error looking for "prompt" after successfully loading "pyvenv.cfg", where that config file doesn't have that key defined. (Side note: Key() will create a new key with an empty value, according to the source.)

I have patched and tested "on my own machine".

@philion philion changed the title Adding venv check for VIRTUAL_ENV_PROPT and assuring an empty 'prompt… Adding venv check for VIRTUAL_ENV_PROMPT and assuring an empty 'prompt… Dec 13, 2023
@scop
Copy link
Contributor

scop commented Jun 18, 2024

I believe these were more/less covered by the merged PR's #387 and #389.

@philion
Copy link
Author

philion commented Jun 25, 2024

Concurring with @scop . Happy with the recent merges.

@philion philion closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philion @scop