Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jwmcglynn
Copy link
Owner

Summary

  • add CSS Color 4 CRD links to each SVG2 color coverage row and split combined entries into individual functions
  • shorten notes to keep line lengths within repository guidelines and reflect color-profile migration to Color 5 change log

Testing

  • not run (documentation-only change)

Codex Task

add ColorSpaceId/ColorSpaceValue and conversion helpers so Color::asRGBA handles hwb, lab/lch, oklab/oklch, XYZ, P3, A98, ProPhoto, Rec2020, and linear sRGB
support color() parsing with optional ColorProfileRegistry plus @color-profile alias binding and expanded parser tests
document the SVG2 color-space pipeline and update release notes for the new coverage

Next steps:
- Rework ColorProfileParser to integrate with the existing stylesheet parsing and not parse its own string
- Establish common patterns with @font-face integration
- Remove ColorProfile::ParseStylesheet
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 49.03801% with 1086 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.32%. Comparing base (b82e062) to head (b9b5e33).

Files with missing lines Patch % Lines
donner/css/parser/ColorParser.cc 43.34% 768 Missing and 181 partials ⚠️
donner/css/parser/StylesheetParser.cc 34.86% 57 Missing and 14 partials ⚠️
donner/css/parser/ColorProfileParser.cc 56.96% 19 Missing and 15 partials ⚠️
donner/css/Color.cc 86.99% 31 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   81.89%   78.32%   -3.58%     
==========================================
  Files         261      264       +3     
  Lines       17230    19107    +1877     
  Branches     3084     3472     +388     
==========================================
+ Hits        14111    14966     +855     
- Misses       2381     3208     +827     
- Partials      738      933     +195     
Flag Coverage Δ
unittests 78.32% <49.03%> (-3.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants