Thank you @Azquelt for taking a further look at this.

Ok, so to check I have this right, every file should begin with a comment saying either:
 Copyright {year}, {owner}, and individual contributors
 by the @authors tag. See the copyright.txt in the distribution for a
 full listing of individual contributors.

Based on the EF Handbook, I think the following lines should be removed:

by the @authors tag. See the copyright.txt in the distribution for a
full listing of individual contributors.

@starksm64 please confirm.

Copyright (c) {year} Contributors to the Eclipse Foundation

Followed by:

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Where {year} is the year when the file was first published and {owner} is the copyright owner of the original contribution.

I have a few additional questions:

1. Should we add this info to CONTRIBUTING.adoc so that new users can find it?

yes. This is a requirement by EF Handbook. It was missed in the past. We need to add it for both cdi and cdi-tck project in this release.

2. I couldn't find the copyright.txt file mentioned in the first header. Should that exist somewhere?

3. The first header says to check the `@author` tag for the copyright owner, whereas NOTICES.md says
   > For more information regarding authorship of content, please consult the listed **source code repository logs**.
   
   
   Does that discrepancy need to be corrected?

The confusing text should be removed. See my comments above.

Add EF copyright and license to all files #741

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions