fully incorporate id(this) into JDQL #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojava
approved these changes
Mar 27, 2024
njr-11
requested changes
Mar 27, 2024
otaviojava
reviewed
Mar 27, 2024
njr-11
approved these changes
Mar 27, 2024
Merged
otaviojava
approved these changes
Apr 3, 2024
|
@gavinking could you rebase this one? |
|
I will, but we have not decided to do it yet. |
|
@gavinking can you rebase this one, please? |
With suggestions from code review Co-authored-by: Nathan Rauh <[email protected]>
Yep, done. |
njr-11
reviewed
Nov 20, 2024
Co-authored-by: Nathan Rauh <[email protected]>
njr-11
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal, in case we want this in 1.0.