fix up treatment of null restrictions #971
Conversation
we need this because "== NULL" and "IS NULL" aren't the same thing
| */ | ||
| package jakarta.data.metamodel.restrict; | ||
|
|
||
| public enum UnaryOperator { |
There was a problem hiding this comment.
Why not here?
I mean, those are Operator, right?
There was a problem hiding this comment.
A BasicRestriction can have a (binary) Operator. A UnaryExpression can have a UnaryOperator. Type safety calls for them to be different types.
There was a problem hiding this comment.
I agree, as long as BasicRestriction and UnaryRestriction are two separate classes, it makes sense to have Operator and UnaryOperator. If we didn't have UnaryRestriction and instead BasicRestriction represented both, then it would make sense to have only Operator. The case for keeping them separate would be that the value() of BasicRestriction is unused in the case of unary. The case for combining them would be having less interfaces/classes.
api/src/main/java/jakarta/data/metamodel/restrict/UnaryOperator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/jakarta/data/metamodel/restrict/UnaryRestriction.java
Outdated
Show resolved
Hide resolved
api/src/main/java/jakarta/data/metamodel/restrict/UnaryRestrictionRecord.java
Outdated
Show resolved
Hide resolved
| */ | ||
| package jakarta.data.metamodel.restrict; | ||
|
|
||
| public enum UnaryOperator { |
There was a problem hiding this comment.
I agree, as long as BasicRestriction and UnaryRestriction are two separate classes, it makes sense to have Operator and UnaryOperator. If we didn't have UnaryRestriction and instead BasicRestriction represented both, then it would make sense to have only Operator. The case for keeping them separate would be that the value() of BasicRestriction is unused in the case of unary. The case for combining them would be having less interfaces/classes.
api/src/main/java/jakarta/data/metamodel/restrict/Restrict.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Rauh <[email protected]>
This makes the following changes:
UnaryRestrictionandUnaryOperatorto representis nullandis not null.nullas a value inBasicRestriction, since the meaning of= nulland<> nullvaries between datastores.