Add Singapore datacenter, update BulbDevice for non-bulb devices again #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
In addition to the new Singapore data center, I also added aliases for a few of the existing ones to better match the official list: {
"login": true,
"result": [
{
"code": "AY",
"name": "China Data Center",
"url": "https://openapi.tuyacn.com"
},
{
"code": "EU",
"name": "Central Europe Data Center",
"url": "https://openapi.tuyaeu.com"
},
{
"code": "IN",
"name": "India Data Center",
"url": "https://openapi.tuyain.com"
},
{
"code": "AZ",
"name": "Western America Data Center",
"url": "https://openapi.tuyaus.com"
},
{
"code": "WE",
"name": "Western Europe Data Center",
"url": "https://openapi-weaz.tuyaeu.com"
},
{
"code": "UE",
"name": "Eastern America Data Center",
"url": "https://openapi-ueaz.tuyaus.com"
},
{
"code": "SG",
"name": "Singapore Data Center",
"url": "https://openapi-sg.iotbing.com"
}
],
"t": ,
"success": true,
"status": "ok"
} |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for a new Singapore data center and refines device configuration logic for non-bulb devices while incrementing the core version.
- Added Singapore region options with appropriate aliases in wizard prompts and Cloud API logic.
- Updated non-bulb device detection in BulbDevice and introduced a default DPSET for non-bulb devices.
- Incremented version in tinytuya/core/core.py to reflect these changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tinytuya/wizard.py | Updated region list and prompt to include Singapore and alias details. |
| tinytuya/core/core.py | Incremented version number from 1.17.1 to 1.17.2. |
| tinytuya/Cloud.py | Extended API region handling to support alias values and Singapore region. |
| tinytuya/BulbDevice.py | Modified device detection logic and added a default DPSET entry for non-bulb devices. |
Comments suppressed due to low confidence (2)
tinytuya/BulbDevice.py:123
- [nitpick] Using the string 'None' as a key in DEFAULT_DPSET may be ambiguous. Consider using a more descriptive key such as 'nonbulb' to clearly denote non-bulb devices.
DEFAULT_DPSET['None'] = {
tinytuya/BulbDevice.py:867
- The revised detection logic distinguishing non-bulb devices is not immediately clear. Adding a brief comment to explain why the presence of keys '20' and '1' indicates a non-bulb device would aid future maintainability.
if '20' in response['dps'] and '1' in response['dps']:
|
Thanks @uzlonewolf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #624
Closes #572 (again)