Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sirosen
Copy link
Member

@sirosen sirosen commented Jul 31, 2025

Update the 'pipsupported' build, now that there's a new release.

Contributor checklist
  • Included tests for the changes.
  • A change note is created in changelog.d/ (see changelog.d/README.md for instructions) or the PR text says "no changelog needed".
Maintainer checklist
  • If no changelog is needed, apply the skip-changelog label.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@sirosen sirosen force-pushed the update-pipsupported-25.2 branch from 3aca9ab to 7f91916 Compare July 31, 2025 13:14
@sirosen sirosen marked this pull request as ready for review July 31, 2025 13:14
@webknjaz
Copy link
Member

Do we have pip unpinned in RTD / Sphinx land?

@webknjaz
Copy link
Member

By the way, there was talk about rephrasing the tox factors. I think @hugovk mentioned it being confusing.. But that would be a separate PR, of course.

@sirosen
Copy link
Member Author

sirosen commented Jul 31, 2025

Do we have pip unpinned in RTD / Sphinx land?

Yeah, it looks like it. I'm surprised by it, but I'll take a look. Maybe just fold it into this fix, since it's "also pinning pip".

@webknjaz
Copy link
Member

webknjaz commented Jul 31, 2025

Oh.. RTD is still configured with their control.

Could you convert it to use this config instead https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/27bdb93/.readthedocs.yaml, in a separate PR?

This also requires a small change in tox: https://github.com/ansible/awx-plugins/blob/c4180cd/tox.ini#L373-L394

@webknjaz
Copy link
Member

I'm surprised by it

I bet the GHA job doesn't fail only because the wheels are cached and the installer doesn't bother to look for newer ones. Looking at docs/requirements.txt, pip isn't pinned in there because docs/requirements.in doesn't actually include .. But since sphinx.ext.autodoc would attempt importing various bits of piptools, it makes sense that it hit a change related to the pip 25.2 release.

@sirosen sirosen force-pushed the update-pipsupported-25.2 branch from 7f91916 to 7d21c57 Compare September 25, 2025 21:02
@sirosen sirosen force-pushed the update-pipsupported-25.2 branch from 7d21c57 to be571d0 Compare September 25, 2025 21:02
@sirosen
Copy link
Member Author

sirosen commented Sep 25, 2025

I've given this a rebase to try to get things in order for us to do a 7.5.1 release.

Also addressed the feedback by adding a byline. (And if you look at the PR history, you'll see that I got the co-authorship wrong at first and amended it. 😅 )

@webknjaz webknjaz added this pull request to the merge queue Sep 26, 2025
Merged via the queue into jazzband:main with commit 74566f9 Sep 26, 2025
43 checks passed
jayaddison added a commit to openculinary/pip-tools that referenced this pull request Sep 26, 2025
@sirosen sirosen deleted the update-pipsupported-25.2 branch September 26, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants