-
-
Notifications
You must be signed in to change notification settings - Fork 634
Update the 'pipsupported' version to 25.2 #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3aca9ab to
7f91916
Compare
|
Do we have pip unpinned in RTD / Sphinx land? |
|
By the way, there was talk about rephrasing the tox factors. I think @hugovk mentioned it being confusing.. But that would be a separate PR, of course. |
Yeah, it looks like it. I'm surprised by it, but I'll take a look. Maybe just fold it into this fix, since it's "also pinning |
|
Oh.. RTD is still configured with their control. Could you convert it to use this config instead https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/27bdb93/.readthedocs.yaml, in a separate PR? This also requires a small change in tox: https://github.com/ansible/awx-plugins/blob/c4180cd/tox.ini#L373-L394 |
I bet the GHA job doesn't fail only because the wheels are cached and the installer doesn't bother to look for newer ones. Looking at |
7f91916 to
7d21c57
Compare
Co-authored-by: James Addison <[email protected]>
7d21c57 to
be571d0
Compare
|
I've given this a rebase to try to get things in order for us to do a 7.5.1 release. Also addressed the feedback by adding a byline. (And if you look at the PR history, you'll see that I got the co-authorship wrong at first and amended it. 😅 ) |
Update the 'pipsupported' build, now that there's a new release.
Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".Maintainer checklist
skip-changeloglabel.