Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sirosen
Copy link
Member

@sirosen sirosen commented Sep 26, 2025

The pip versions being tested are controlled via a JSON array passed as
a string. Use the same mechanism to pass CPython versions to test.

This allows PR builds to continue to test 3.8 (EOL) and 3.9 (EOL soon)
while nightly builds will only run on 3.10+ .

Resolves #2226

Contributor checklist
  • Included tests for the changes.
  • A change note is created in changelog.d/ (see changelog.d/README.md for instructions) or the PR text says "no changelog needed".
Maintainer checklist
  • If no changelog is needed, apply the skip-changelog label.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@sirosen sirosen added this to the 7.5.1 milestone Sep 26, 2025
@sirosen sirosen requested a review from webknjaz September 26, 2025 15:13
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.. This is fine short-term but what I really want is to push matrix definitions out of the reusable workflows so the reusable workflow would only have one job with one python/os/arch combo. This worked really well for reusable-tox.yml and we should work towards moving in the direction of the same style.

When this is done, we'd be able to control pairs of pip+python more granularly, on the calling side.

@@ -0,0 +1,2 @@
Narrow the CPython versions tested in nightly CI runs and separate these from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-imperative plz?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll fix it up.

@sirosen
Copy link
Member Author

sirosen commented Sep 26, 2025

This is fine short-term but what I really want is to push matrix definitions out of the reusable workflows so the reusable workflow would only have one job with one python/os/arch combo.

This sounds like a wonderful longer term solve. Let's queue it up as something to work on.

I'm not a huge fan of the current solution, but I saw it as the shortest path towards healthier CI. (And this was listed for 7.5.1 so I wanted to choose either "put in a relatively easy solution" or "explicitly move it to 7.5.2".)

@sirosen sirosen force-pushed the bump-nightly-ci-job-to-310 branch from c425ea0 to 31a60bb Compare September 26, 2025 18:04
The pip versions being tested are controlled via a JSON array passed as
a string. Use the same mechanism to pass CPython versions to test.

This allows PR builds to continue to test 3.8 (EOL) and 3.9 (EOL soon)
while nightly builds will only run on 3.10+ .
@sirosen sirosen force-pushed the bump-nightly-ci-job-to-310 branch from 31a60bb to cd233dd Compare September 26, 2025 18:06
@sirosen sirosen enabled auto-merge September 26, 2025 18:06
@sirosen sirosen added this pull request to the merge queue Sep 26, 2025
Merged via the queue into jazzband:main with commit 9b4de7d Sep 26, 2025
43 checks passed
@sirosen sirosen deleted the bump-nightly-ci-job-to-310 branch September 26, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Python 3.8 jobs against pip's main branch in nightly CI to Python 3.9

2 participants