Fix #410 slow metadata save not closing resources #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirostar
commented
Apr 16, 2020
- Change Java Version to 8 because of org.jcodec.api.transcode.SinkImpl using java.lang.reflect.Parameter
- Close inputs at slow metadata save and delete and then move. This also fixes the test testKeyedWriteSlow() (on Windows)
* Change Java Version to 8 because of org.jcodec.api.transcode.SinkImpl using java.lang.reflect.Parameter * Close inputs at slow metadata save and delete and then move. This also fixes the test testKeyedWriteSlow() (on Windows)
Author
|
Is something wrong with this pull request? |
svitvitskiy
reviewed
Apr 23, 2020
| <encoding>UTF-8</encoding> | ||
| <source>1.6</source> | ||
| <target>1.6</target> | ||
| <source>8</source> |
Collaborator
There was a problem hiding this comment.
I wouldn't change the source version. We try to keep the code backwards compatible. IMO there's no reason we might need the features of java 8.
svitvitskiy
reviewed
Apr 23, 2020
Collaborator
svitvitskiy
left a comment
There was a problem hiding this comment.
Please see my comments
|
|
||
| for (int i = 0; i < tracks.length; i++) { | ||
| writers[i].apply(); | ||
| writers[i].close(); |
Collaborator
There was a problem hiding this comment.
Close should be handled outside of this code.
| flattenChannel(movie, out); | ||
| } finally { | ||
| if (out != null) | ||
| out.close(); |
Collaborator
There was a problem hiding this comment.
I think we are already closing the file right here, so that should be sufficient.
# Conflicts: # src/main/java/org/jcodec/containers/mp4/ChunkWriter.java # src/main/java/org/jcodec/movtool/Flatten.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.