Document changes in 2.2.0 #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we refactor to allow for both? This is very unfortunate :( |
Contributor
|
This change was released in v2.2.0 a few months ago. Looks like gh-pages moved from v2.1 to v2.4 for minima a few weeks ago: https://github.com/github/pages-gem/releases/tag/v179 Is this happening often? |
ashawley
approved these changes
Mar 26, 2018
Contributor
ashawley
left a comment
There was a problem hiding this comment.
LGTM. Hopefully, that diff link to footer.html is sufficient.
Member
Author
|
The build error will occur for people with a customized footer that references former includes for social links. We reintroduced these includes in #217 to avoid that. To use the new social links, people will need to update their |
parkr
approved these changes
Mar 31, 2018
Member
Author
|
We reintroduce missing includes in #217 to avoid the build error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People upgrading from previous versions can face errors at build 😢
fix #215