Fixed bug when testing browser version for Opera or IE #138 #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other assertions are failed. I think this approach isn't a good way to solve this issue. |
peter279k
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
For this PR, it looks good to me.
Just wait for owner @jenssegers reply :).
|
@peter279k added a test that will verify each browser works with a fake user agent string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138
This fixes an issue with detecting the browser version if the mobile detect library returns an array of parameters instead of a string.
There may be a better way to handle this so that the preg_match in the version method doesnt have duplicated items in it, but this should work to prevent any errors if it gets that far.