Allow each component to have its own colors and default to global ones #3086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea. Will have a look at the PR. |
|
Thanks! I'm still noodling on what I'd love to see out of buttons — at the moment I've locally overridden the text colors, and I'm not using light and dark variants at all, so I've got it working, but it's not clean in the slightest. But in general, I'm going for WCAG contrast and that's turning out hard to achieve in places. |
|
I definitely think this would be a nice addition. Full disclosure, I work with @aredridel so I am probably biased, but objectively having more control if a developer wants it seems like a win to me. |
7617782 to
01cf4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature.
Proposed solution
Tags and buttons did not have enough contrast for our use case, and we wanted to use a dark grey body text in most situations such as messages, not a darker flavor of the background color. It is simple enough to add intermediate variables as customization points for the colors of each element or component, allowing us to do this. It's not perfect — buttons still make more assumptions about how colors are related than we'd like — but it goes a long way toward making Bulma customizable for our uses.
Tradeoffs
Testing Done
Changelog updated?
No. It's unclear how to do so for unreleased changes, and it appears it's maintained more periodically in practice than with each PR.