Apply custom footer and custom MkDocs Theme #722
Merged
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
reviewed
Oct 30, 2025
|
We have to adapt this PR to download https://github.com/jolicode/oss-footer/blob/main/snippet-joli-footer.html at build time instead. |
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MkDocs footer implementation to use external assets from the jolicode/oss-theme repository. The copyright notice is removed from the MkDocs configuration and replaced with a dynamic footer that includes custom branding and styling.
- Adds a new
fetch_assets()task to download external CSS and footer HTML from the jolicode/oss-theme repository - Removes hardcoded copyright from mkdocs.yml and implements a custom footer partial
- Updates both build and serve tasks to fetch assets before execution
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/mkdocs/castor.php | Adds fetch_assets() function to download external assets and integrates it into build/serve tasks |
| tools/mkdocs/mkdocs.yml | Removes copyright field and adds reference to new jolicode.css stylesheet |
| tools/mkdocs/overrides/main.html | Adds footer block that includes the jolicode-footer.html partial |
| tools/mkdocs/.gitignore | Ignores the dynamically downloaded jolicode-footer.html file |
| .gitignore | Ignores the dynamically downloaded jolicode.css file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6e8815f to
f76e3bc
Compare
damienalexandre
approved these changes
Oct 31, 2025
|
@jonathanlevaillant 👋❤️😄 |
|
Hey @tigitz ! 👋💛😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.