Check the retval of waitpid before errno #6489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in jruby#6477 it appears that a successful waitpid under some circumstances is leaving errno set, either to 11 (EAGAIN) or in some situation 2 (ENOENT). The reasons for this unsanitary errno handling are not clear, but the logic in JRuby should at least be checking for a -1 retval before assuming there was an error. This commit makes that modification which should avoid the error reported in jruby#6477. This constitutes a "fix" of sorts, but we still don't know why the cicumstances in jruby#6477 lead to this errno result. Fixes jruby#6477.
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #6477 it appears that a successful waitpid under
some circumstances is leaving errno set, either to 11 (EAGAIN) or
in some situation 2 (ENOENT). The reasons for this unsanitary
errno handling are not clear, but the logic in JRuby should at
least be checking for a -1 retval before assuming there was an
error. This commit makes that modification which should avoid the
error reported in #6477.
This constitutes a "fix" of sorts, but we still don't know why the
cicumstances in #6477 lead to this errno result.
Fixes #6477.