Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: mapping values are not allowed in this context in ValuesFromHelm #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

fix: mapping values are not allowed in this context in ValuesFromHelm #250

merged 4 commits into from
Apr 30, 2025

Conversation

@denis-ryzhkov
Copy link
Collaborator

  • Before the fix:
cat >child-values.yaml <<EOF
collectors:
  opencost:
    enabled: false
EOF

helm upgrade -i --reset-values --wait -n kof kof-child ./charts/kof-child \
  -f child-values.yaml

  Error: UPGRADE FAILED: YAML parse error on
  kof-child/templates/child-multi-cluster-service.yaml:
  error converting YAML to JSON: yaml: line 49:
  mapping values are not allowed in this context
  • After the fix:
helm upgrade -i --reset-values --wait -n kof kof-child ./charts/kof-child \
  -f child-values.yaml

  STATUS: deployed

kubectl get mcs kof-child-cluster -o yaml

  ...
  {{ $collectorsValuesFromHelm := `
  opencost:
    enabled: false` | fromYaml }}
  {{ $collectorsValuesHere := printf `
  global:
    clusterName: %q
  ...

@denis-ryzhkov denis-ryzhkov requested a review from gmlexx as a code owner April 30, 2025 09:08
@gmlexx
Copy link
Collaborator

gmlexx commented Apr 30, 2025

Thanks for fixing that, but I assume we missed this issue due to the empty values, so let's add some dummy values there to use them for CI

@denis-ryzhkov
test: Added dummy values to test ValuesFromHelm in CI
a2e5e05
@denis-ryzhkov
chore: kof v0.3.1 patch release
897698b
@denis-ryzhkov
test: Revert "test: Added dummy values to test ValuesFromHelm in CI"
deaa341 
Reverted because we don't want dummy values in default values / prod,
and also we don't test kof-istio, kof-child, and kof-regional in CI anyway.

This reverts commit a2e5e05.
@denis-ryzhkov denis-ryzhkov merged commit 11397d2 into k0rdent:main Apr 30, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this to Done in k0rdent Apr 30, 2025
AndrejsPon00 added a commit to AndrejsPon00/kof that referenced this pull request May 28, 2025
@AndrejsPon00 @denis-ryzhkov
@gmlexx @ramessesii2 @aglarendil
React server (#6)
274d7ca 
* chore: kof v0.3.0 pre-release (k0rdent#236)

* fix: "Insufficient cpu" for istio-regional (k0rdent#237)

* feat: Added ServiceMonitor for alertmanager (k0rdent#239)

* fix: `Label does not exist` on `removeLabel` when multiple triage CI jobs are triggered (k0rdent#245)

* feat: Added `alertmanager` Grafana datasource (k0rdent#243)

* Added `alertmanager` Grafana datasource.
* Deleted `agg-prometheus` datasource as a duplicate of `victoriametrics` datasource.
* Fixed minor issues.
* Workaround for CI error `deployments.apps "addon-controller" not found`

* feat: add control plane monitoring with otel mtls setup (k0rdent#244)

* fix: `mapping values are not allowed in this context` in `ValuesFromHelm` (k0rdent#250)

* chore: Re-releasing kof v0.3.0 to include latest fixes (k0rdent#252)

* Migrate to v1beta1 (k0rdent#256)

* feat: add nvidia gpu monitoring dashboard to grafana (k0rdent#257)

Signed-off-by: Satyam Bhardwaj <[email protected]>

* chore: remove KCM upgrade from KOF upgrade test (k0rdent#260)

* feat: adopting kube-api-server service monitor from opentelemetry-kube-stack (k0rdent#259)

* feat: extend resources customization for grafana and vmcluster (k0rdent#263)

* chore: bump go version to upcomming upgrade (k0rdent#269)

Bump go version to prevent CI falure due outdated version

* chore: bump go version for upcomming upgrade (k0rdent#271)

* fix: istio remote secret creation (k0rdent#270)

* feat: add cluster annotation to customize promxy and datasource http config (k0rdent#276)

* feat: move to victoria-log-cluster (k0rdent#274)

* chore: bump helm charts versions to v1.0.0 (k0rdent#277)

* test: Debug `"helm repo add" requires 2 arguments` in `workflows/release_charts` (k0rdent#280)

* fix: `"helm repo add" requires 2 arguments` in `workflows/release_charts` exposed by fix in yq v4.45.4 (k0rdent#282)

* fix: support modification of resources for all VM services (k0rdent#279)

closes k0rdent#261

misc: fix replicationFactor keys location as well

* chore: kof 1.0.0-rc2 using kcm 1.0.0-rc1 and kcm api v1beta1 (k0rdent#284)

* chore: kof 1.0.0 using kcm 1.0.0 (k0rdent#285)

* feat: add kof-operator internal observability UI

* Fix golang test

* Add toast library

* Remove mutex

* Remove unnecessary target fetch

* Add loading and empty data layout

* Fix console error

* Refactor PrometheusTargets provider

* Cleanup

* Add adopted cluster support

* Refactor prometheus handler

* Apply suggested improvements and fixes

* Fix linter issue

* Fix table layout

* Backend refactoring

* Frontend refactoring

* Fix linter issues

* Add linter check to workflow

* Fix bad date handling

* Add more context to logs

---------

Signed-off-by: Satyam Bhardwaj <[email protected]>
Co-authored-by: Denis Ryzhkov <[email protected]>
Co-authored-by: Aleksei Larkov <[email protected]>
Co-authored-by: Satyam Bhardwaj <[email protected]>
Co-authored-by: Vladimir Kuklin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlexx gmlexx gmlexx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

k0rdent
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denis-ryzhkov @gmlexx