Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: fix Victoria dashboard tests in KOF UI #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

test: fix Victoria dashboard tests in KOF UI #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"singleQuote": false,
"proseWrap": "preserve",
"bracketSpacing": true,
"trailingComma": "none",
"trailingComma": "all",
"printWidth": 88
}
15 changes: 10 additions & 5 deletions ...ctor/src/components/pages/collectorPage/components/collector-details/CollectorContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { Tabs, TabsList, TabsTrigger } from "@/components/generated/ui/tabs";
import {
Tabs,
TabsContent,
TabsList,
TabsTrigger,
} from "@/components/generated/ui/tabs";
import { JSX, useEffect } from "react";
import CollectorProcessorTab from "./CollectorProcessorTab";
import CollectorReceiverTab from "./CollectorReceiverTab";
Expand Down Expand Up @@ -90,14 +95,14 @@ const CollectorContent = (): JSX.Element => {
<TabsTrigger value="process">Process</TabsTrigger>
<TabsTrigger value="raw_json">Raw Metrics</TabsTrigger>
</TabsList>
<CollectorOverviewTab
collector={selectedCollector}
></CollectorOverviewTab>
<CollectorOverviewTab collector={selectedCollector} />
<CollectorExporterTab />
<CollectorProcessorTab />
<CollectorReceiverTab />
<CollectorProcessTab />
<RawJsonTab object={selectedCollector.getMetrics()} />
<TabsContent value="raw_json">
<RawJsonTab object={selectedCollector.getMetrics()} />
</TabsContent>
</Tabs>
</div>
);
Expand Down
11 changes: 9 additions & 2 deletions ...bapp/collector/src/components/pages/victoriaPage/victoria-details/VictoriaDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ import { useNavigate, useParams } from "react-router-dom";
import { Separator } from "@/components/generated/ui/separator";
import { Loader, MoveLeft } from "lucide-react";
import { Button } from "@/components/generated/ui/button";
import { Tabs, TabsList, TabsTrigger } from "@/components/generated/ui/tabs";
import {
Tabs,
TabsContent,
TabsList,
TabsTrigger,
} from "@/components/generated/ui/tabs";
import UnhealthyAlert from "@/components/shared/UnhealthyAlert";
import VictoriaPageHeader from "../VictoriaPageHeader";
import VictoriaOverviewTab from "./VictoriaOverviewTab";
Expand Down Expand Up @@ -147,7 +152,9 @@ const VictoriaDetailsPage = (): JSX.Element => {
<VictoriaLogsInsertTab />
<VictoriaLogsSelectTab />
<VictoriaLogsStorageTab />
<RawJsonTab object={selectedPod.getMetrics()} />
<TabsContent value="raw_json">
<RawJsonTab object={selectedPod.getMetrics()} />
</TabsContent>
</Tabs>
</div>
);
Expand Down
55 changes: 26 additions & 29 deletions kof-operator/webapp/collector/tests/MetricsCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { render, renderHook, screen } from "@testing-library/react";
import {
MetricsCard,
MetricCardRow,
MetricRow,
CustomRowProps,
} from "../src/components/shared/MetricsCard";
import React, { act } from "react";
Expand All @@ -22,7 +22,7 @@ describe("Metrics Card", () => {
vi.fn().mockResolvedValue({
ok: true,
json: () => Promise.resolve(fakeVictoriaResponse),
})
}),
);

vi.mock("../../src/metrics/MetricsDatabase", () => {
Expand All @@ -49,9 +49,7 @@ describe("Metrics Card", () => {
result.current.setSelectedCluster("aws-ue2");
});
await act(async () => {
result.current.setSelectedPod(
result.current.selectedCluster?.pods[0].name || ""
);
result.current.setSelectedPod(result.current.selectedCluster?.pods[0].name || "");
});
});

Expand All @@ -66,7 +64,7 @@ describe("Metrics Card", () => {
});
});

it("should renders nothing if no rows array is empty", async () => {
it("should render nothing if the rows array is empty", async () => {
const title = "No Rows";

render(
Expand All @@ -75,7 +73,7 @@ describe("Metrics Card", () => {
icon={MockIcon}
title={title}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(title)).toBeInTheDocument();
Expand All @@ -87,20 +85,21 @@ describe("Metrics Card", () => {
it("should render card row with metricFetchFn", () => {
const cardTitle = "Test Card";

const rows: MetricCardRow[] = [
const rows: MetricRow[] = [
{
title: "Custom Metric",
metricFetchFn: () => 123,
metricFormat: (v) => `${v} units`,
},
];

render(
<MetricsCard
rows={rows}
icon={MockIcon}
title={cardTitle}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
Expand All @@ -118,10 +117,10 @@ describe("Metrics Card", () => {
it("should render card row with metricName and no trend", () => {
const cardTitle = "Rows Card";

const rows: MetricCardRow[] = [
const rows: MetricRow[] = [
{
title: "HTTP Requests",
metricName: VICTORIA_METRICS.VM_HTTP_REQUESTS_TOTAL,
title: "CPU Count",
metricName: VICTORIA_METRICS.GO_CGO_CALLS_COUNT.name,
},
];

Expand All @@ -131,7 +130,7 @@ describe("Metrics Card", () => {
icon={MockIcon}
title={cardTitle}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
Expand All @@ -142,17 +141,17 @@ describe("Metrics Card", () => {
const contentRows = cardContent?.childNodes;
expect(contentRows).toHaveLength(1);

expect(screen.getByText("HTTP Requests")).toBeInTheDocument();
expect(screen.getByText("39107")).toBeInTheDocument();
expect(screen.getByText("CPU Count")).toBeInTheDocument();
expect(screen.getByText("27074437")).toBeInTheDocument();
});

it("should render card row with enableTrendSystem", () => {
const cardTitle = "CPU";

const rows: MetricCardRow[] = [
const rows: MetricRow[] = [
{
title: "Seconds Total",
metricName: VICTORIA_METRICS.GO_GC_CPU_SECONDS_TOTAL,
metricName: VICTORIA_METRICS.GO_GC_CPU_SECONDS_TOTAL.name,
enableTrendSystem: true,
metricFormat: (v) => `${v}s`,
},
Expand All @@ -164,11 +163,11 @@ describe("Metrics Card", () => {
icon={MockIcon}
title={cardTitle}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
expect(screen.getByText("16.343930724s")).toBeInTheDocument();
expect(screen.getByText("270.463318726s")).toBeInTheDocument();
});

it("should render card with custom row", () => {
Expand All @@ -180,7 +179,7 @@ describe("Metrics Card", () => {
</div>
);

const rows: MetricCardRow[] = [
const rows: MetricRow[] = [
{
title: "Custom Row",
metricFetchFn: () => 77,
Expand All @@ -195,13 +194,11 @@ describe("Metrics Card", () => {
icon={MockIcon}
title={cardTitle}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
expect(screen.getByTestId("custom-row")).toHaveTextContent(
"Custom Row: 77x"
);
expect(screen.getByTestId("custom-row")).toHaveTextContent("Custom Row: 77x");
});

it("should render card with description", () => {
Expand All @@ -214,7 +211,7 @@ describe("Metrics Card", () => {
title={cardTitle}
state={useVictoriaMetricsState}
description="This is a description"
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
Expand All @@ -223,15 +220,15 @@ describe("Metrics Card", () => {

it("should render card with multiple rows correctly", () => {
const cardTitle = "Multiple Rows Card";
const rows: MetricCardRow[] = [
const rows: MetricRow[] = [
{
title: "Row 1",
metricFetchFn: () => 10,
metricFormat: (v) => `${v}%`,
},
{
title: "Row 2",
metricName: VICTORIA_METRICS.VM_HTTP_REQUESTS_TOTAL,
metricName: VICTORIA_METRICS.VM_ROWS_DELETED_TOTAL.name,
},
{
title: "Row 3",
Expand All @@ -246,7 +243,7 @@ describe("Metrics Card", () => {
icon={MockIcon}
title={cardTitle}
state={useVictoriaMetricsState}
/>
/>,
);

expect(screen.getByText(cardTitle)).toBeInTheDocument();
Expand All @@ -258,7 +255,7 @@ describe("Metrics Card", () => {
expect(screen.getByText("10%")).toBeInTheDocument();

expect(screen.getByText("Row 2")).toBeInTheDocument();
expect(screen.getByText("39107")).toBeInTheDocument();
expect(screen.getByText("3912")).toBeInTheDocument();

expect(screen.getByText("Row 3")).toBeInTheDocument();
expect(screen.getByText("42s")).toBeInTheDocument();
Expand Down
Loading
Loading