fix: support artifact re-upload #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
b3ee482 to
b1f1af0
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
Code Metrics Report
Details | | main (e8d457e) | #564 (36327df) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 51.7% | 51.5% | -0.2% |
| Files | 53 | 53 | 0 |
| Lines | 3946 | 3963 | +17 |
+ | Covered | 2042 | 2043 | +1 |
- | Code to Test Ratio | 1:0.6 | 1:0.6 | -0.1 |
| Code | 7682 | 7708 | +26 |
| Test | 4869 | 4869 | 0 |
+ | Test Execution Time | 29s | 26s | -3s |Code coverage of files in pull request scope (28.9% → 28.3%)
Benchmark-0 (this is custom metrics test)
Benchmark-1 (this is custom metrics test)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the artifact storage logic to improve how artifacts are uploaded and managed in GitHub Actions. The main changes involve passing explicit repository and workflow run information to artifact uploads and ensuring old artifacts with the same name are deleted before uploading new ones.
Artifact upload improvements:
PutArtifactmethod ingh.gonow requires explicitowner,repo, andrunIDparameters, and deletes any existing artifact with the same name before uploading the new one. This prevents duplicate artifacts and ensures the latest artifact is always stored.Putmethod inartifact.gois updated to parse the repository information and retrieve theGITHUB_RUN_IDfrom the environment, passing these values toPutArtifact. This ensures the artifact is associated with the correct workflow run and repository.Dependency and import changes:
osandstrconvinartifact.goto support environment variable access and string-to-integer conversion.